Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBI::File's printer doesn't print root node comments when no other nodes are present #84

Closed
mutecipher opened this issue Oct 5, 2021 · 0 comments · Fixed by #85
Closed

RBI::File's printer doesn't print root node comments when no other nodes are present #84

mutecipher opened this issue Oct 5, 2021 · 0 comments · Fixed by #85
Assignees
@Morriar
Labels
bug Something isn't working

Comments

@mutecipher
Copy link
Contributor

Current behaviour:

rbi = RBI::File.new(strictness: "true")
rbi.root.comments << RBI::Comment.new("foo")
rbi.string
# "# typed: true\n"

Expected behaviour:

rbi = RBI::File.new(strictness: "true")
rbi.root.comments << RBI::Comment.new("foo")
rbi.string
# "# typed: true\n\n# foo\n"
@mutecipher mutecipher added the bug Something isn't working label Oct 5, 2021
Morriar added a commit that referenced this issue Oct 5, 2021
@Morriar
Print empty trees with comments
a7c39a1 
Fixes #84.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar mentioned this issue Oct 5, 2021
Merged
@Morriar Morriar self-assigned this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Morriar Morriar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print empty trees with comments Shopify/rbi
2 participants
@Morriar @mutecipher