Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not compile on android #2409

Closed
isaiass18 opened this issue Apr 27, 2024 · 2 comments
Closed

does not compile on android #2409

isaiass18 opened this issue Apr 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@isaiass18
Copy link

isaiass18 commented Apr 27, 2024

Description

In windows 10
When I try to compile the project it gives me errors. I created a new project and installed only skia but the problem persists.

I am using JDK 17, ndk correct

Captura de pantalla 2024-04-27 180508
Captura de pantalla 2024-04-27 180534

Version

^1.2.3

Steps to reproduce

{
"name": "skia",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"lint": "eslint .",
"start": "react-native start",
"test": "jest"
},
"dependencies": {
"@shopify/react-native-skia": "^1.2.3",
"react": "18.2.0",
"react-native": "0.74.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@babel/preset-env": "^7.20.0",
"@babel/runtime": "^7.20.0",
"@react-native/babel-preset": "0.74.81",
"@react-native/eslint-config": "0.74.81",
"@react-native/metro-config": "0.74.81",
"@react-native/typescript-config": "0.74.81",
"@types/react": "^18.2.6",
"@types/react-test-renderer": "^18.0.0",
"babel-jest": "^29.6.3",
"eslint": "^8.19.0",
"jest": "^29.6.3",
"prettier": "2.8.8",
"react-test-renderer": "18.2.0",
"typescript": "5.0.4"
},
"engines": {
"node": ">=18"
}
}

Snack, code example, screenshot, or link to a repository

complete log.txt

C:\Users\usuario\AppData\Local\Android\Sdk\ndk\25.1.8937393\toolchains\llvm\prebuilt\windows-x86_64\bin\clang++.exe --target=x86_64-none-linux-android23 --sysroot=C:/Users/usuario/AppData/Local/Android/Sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Drnskia_EXPORTS -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/callinvoker" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/jsi" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/react/nativemodule/core" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/runtimeexecutor" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/jni" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/include" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/rnskia-android" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/skia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/api" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/jsi" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/values" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/base" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/nodes" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/props" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/utils" -isystem C:/Users/usuario/.gradle/caches/transforms-4/c7e26f7d3c2fc1a6636ff1467fc77795/transformed/jetified-fbjni-0.6.0/prefab/modules/fbjni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/react_nativemodule_core/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/jsi/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/reactnativejni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/runtimeexecutor/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/turbomodulejsijni/include -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -std=c++1y -DONANDROID -DSK_GL -DSK_GANESH -DSK_BUILD_FOR_ANDROID -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_HAVE_MEMRCHR=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DON_ANDROID -DONANDROID -fno-limit-debug-info -fPIC -std=gnu++17 -MD -MT CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -MF CMakeFiles\rnskia.dir\cpp\jni\JniPlatformContext.cpp.o.d -o CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -c "H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp"

H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp:23:21: error: use of undeclared identifier 'ANDROID_BITMAP_FLAGS_ALPHA_SHIFT'
switch ((flags >> ANDROID_BITMAP_FLAGS_ALPHA_SHIFT) &
^
C:\Users\usuario\AppData\Local\Android\Sdk\ndk\25.1.8937393\toolchains\llvm\prebuilt\windows-x86_64\bin\clang++.exe --target=x86_64-none-linux-android23 --sysroot=C:/Users/usuario/AppData/Local/Android/Sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Drnskia_EXPORTS -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/callinvoker" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/jsi" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/react/nativemodule/core" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/runtimeexecutor" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/jni" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/include" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/rnskia-android" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/skia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/api" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/jsi" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/values" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/base" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/nodes" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/props" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/utils" -isystem C:/Users/usuario/.gradle/caches/transforms-4/c7e26f7d3c2fc1a6636ff1467fc77795/transformed/jetified-fbjni-0.6.0/prefab/modules/fbjni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/react_nativemodule_core/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/jsi/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/reactnativejni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/runtimeexecutor/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/turbomodulejsijni/include -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -std=c++1y -DONANDROID -DSK_GL -DSK_GANESH -DSK_BUILD_FOR_ANDROID -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_HAVE_MEMRCHR=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DON_ANDROID -DONANDROID -fno-limit-debug-info -fPIC -std=gnu++17 -MD -MT CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -MF CMakeFiles\rnskia.dir\cpp\jni\JniPlatformContext.cpp.o.d -o CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -c "H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp"

H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp:24:11: error: use of undeclared identifier 'ANDROID_BITMAP_FLAGS_ALPHA_MASK'
ANDROID_BITMAP_FLAGS_ALPHA_MASK) {
^
C:\Users\usuario\AppData\Local\Android\Sdk\ndk\25.1.8937393\toolchains\llvm\prebuilt\windows-x86_64\bin\clang++.exe --target=x86_64-none-linux-android23 --sysroot=C:/Users/usuario/AppData/Local/Android/Sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Drnskia_EXPORTS -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/callinvoker" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/jsi" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/react/nativemodule/core" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactCommon/runtimeexecutor" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/jni" -I"H:/girosya/skia test/skia/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/include" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/rnskia-android" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/skia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/api" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/jsi" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/values" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/base" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/nodes" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/rnskia/dom/props" -I"H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/../cpp/utils" -isystem C:/Users/usuario/.gradle/caches/transforms-4/c7e26f7d3c2fc1a6636ff1467fc77795/transformed/jetified-fbjni-0.6.0/prefab/modules/fbjni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/react_nativemodule_core/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/jsi/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/reactnativejni/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/runtimeexecutor/include -isystem C:/Users/usuario/.gradle/caches/transforms-4/813da8d64613d3a874726517fb776e54/transformed/jetified-react-android-0.74.0-debug/prefab/modules/turbomodulejsijni/include -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fexceptions -frtti -std=c++1y -DONANDROID -DSK_GL -DSK_GANESH -DSK_BUILD_FOR_ANDROID -DFOLLY_NO_CONFIG=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -DFOLLY_HAVE_MEMRCHR=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_MOBILE=1 -DON_ANDROID -DONANDROID -fno-limit-debug-info -fPIC -std=gnu++17 -MD -MT CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -MF CMakeFiles\rnskia.dir\cpp\jni\JniPlatformContext.cpp.o.d -o CMakeFiles/rnskia.dir/cpp/jni/JniPlatformContext.cpp.o -c "H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp"

H:/girosya/skia test/skia/node_modules/@shopify/react-native-skia/android/cpp/jni/JniPlatformContext.cpp:46:8: error: use of undeclared identifier 'ANDROID_BITMAP_FORMAT_RGBA_F16'
case ANDROID_BITMAP_FORMAT_RGBA_F16:

@isaiass18 isaiass18 added the bug Something isn't working label Apr 27, 2024
@wcandillon
Copy link
Collaborator

based on the error message it looks like the NDK is not available. Where you able to fix the issue?

@SaeedZhiany
Copy link

SaeedZhiany commented Jul 6, 2024

Hi @wcandillon

I'm getting the same error. I defined the ndkversion in my project gradle and have it in my SDK. Just like the other configuration (buildToolsVersion, compileSdkVersion, ...), I expect react-native-skia to use the defined ndkVersion instead of forcing me to download and use another version.

Do you think it can be fixed soon? Thanks.

image

version 26.1.10909125 is the default version used in the latest version of RN (0.74.3 as I'm writing this comment) while this library is trying to build with version 25.1.8937393

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants