-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video playback issues #2442
Comments
Maybe something like this can be achieved using some flag, when needed? |
@wcandillon ^^ |
I've fixed the framerate issue, now looking into exposing/testing the seek command. About the rotation, do you believe that there is some metadata that should be read and isn't? could you provide a sample video file to test? |
I can confirm that seek seems to work as expected, but please let me know if you have more test cases for me. I'm also interested about the orientation issue. |
@wcandillon Thanks! |
@wcandillon I think usage of |
just to be sure is |
@wcandillon I would go with both getter and setter there. So to have it working with gesture handlers under worklets with |
ok 👍
…On Tue, May 28, 2024 at 3:05 PM OleksiiMaksymov ***@***.***> wrote:
@wcandillon I would go with both getter and setter there. So to have it working with gesture handlers under worklets with useSharedValue.
—
Reply to this email directly, view it on GitHub or unsubscribe.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
🎉 This issue has been resolved in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@wcandillon Update to 1.3.1
Seeking doesn't work as it should (in 90% of the time video is seeked to previous (not next) iframe: here is the video recording: video_2024-05-28_19-40-44.mp4Also checked, the currentTime value is reset to 0 almost every time, even though video is somewhere in the middle of playback duration
|
Regarding current time here is the issue:
So IMHO we just need to change it to:
But also I would get the real currentTime value from native, because there could be a difference because of native selecting iframe (mp4 keyframe) instead of seeked time. |
@wcandillon also I am checking this code:
Maybe here we should use |
@wcandillon Also one more thing regarding rotated videos. When I use file picker to get the video from gallery (I use PS: Thanks for reopening this! |
🎉 This issue has been resolved in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Just in case moving my comments from #1326
I've tried already video feature today, looks good! Only few things find a bit off:
BUT!: After draging here and there app can rendomly crash (android logs point on skia)
Anyway waiting for the new version! If scrubbing on Android will work, this going to be killer feature to use this, instead of RNVideo!
Thanks!
Version
1.3.0
Steps to reproduce
Some issues are random, but everything is in the description
Snack, code example, screenshot, or link to a repository
Standard example from website can show this issues.
The text was updated successfully, but these errors were encountered: