Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rename useProgress to useTimestamp #83

Closed
wcandillon opened this issue Jan 5, 2022 · 0 comments · Fixed by #84
Closed

Suggestion: rename useProgress to useTimestamp #83

wcandillon opened this issue Jan 5, 2022 · 0 comments · Fixed by #84

Comments

@wcandillon
Copy link
Collaborator

I found the naming useProgress problematic:

  • often a progress implies a start and finish which this hook doesn't have
  • When using it, I was trying to control the speed of things and thinking of it as returning a millisecond value was helpful
wcandillon added a commit that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant