Renovations #294
Merged
Renovations #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move to github.com/urface/cli/v2 API - refresh all dependencies to @latest - golang.org/x/crypto/ssh/terminal moved to golang.org/x/term
- deprecated functions - copylocks on range - t.Fatal in non-test goroutines - use bytes.Equal - #nosec for math/crypto
|
@sirupsen 👋 hiya — I'm not sure who still maintains toxiproxy, but as a recent committer is this something you might be able to review? |
|
Thanks, is someone able to merge so I can pull this in from master? |
miry
approved these changes
Aug 11, 2021
miry
added a commit
that referenced
this pull request
Sep 3, 2021
In #294 introduced a breaking change in client argument parsing. It requires to write [flags before arguments](https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args). Update help texts and documentation to have POSIX way to use flags and arguments.
miry
added a commit
that referenced
this pull request
Sep 3, 2021
In #294 introduced a breaking change in client argument parsing. It requires to write [flags before arguments](https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args). Update help texts and documentation to have POSIX way to use flags and arguments.
miry
added a commit
that referenced
this pull request
Sep 3, 2021
In #294 introduced a breaking change in client argument parsing. It requires to write [flags before arguments](https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args). Update help texts and documentation to have POSIX way to use flags and arguments. Co-authored-by: Drew Matheson <DAmatheson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renovate dependencies
gofmt -s -w
fix some minor govet/staticheck failures