[WIP] Split shopinvader in 2 modules base and product #1382
Conversation
|
All this seems to be a hard work. Do you plan to finalize this work in the coming days or do you need some helo on it? Regards, lmi |
|
Hi @lmignon |
matthieusaison
force-pushed
the
14.0-split_shopinvader_v1_product
branch
3 times, most recently
from
761073e
to
ff58e56
Compare
sebastienbeau
force-pushed
the
14.0-split_shopinvader_v1_product
branch
8 times, most recently
from
c1a5af5
to
0206922
Compare
|
Test are green !! \o/ |
|
@lmignon you can start to review |
|
@matthieusaison @sebastienbeau Thank you for this hard work. All this seems to go into the right way. I haven't found any issue at first read of this giant PR. |
sebastienbeau
force-pushed
the
14.0-split_shopinvader_v1_product
branch
4 times, most recently
from
ce9cf08
to
e42e684
Compare
|
|
If the partner do not belong to a specific company the profile is never set we should use the company of the binding (related backend), not the company of the partner
matthieusaison
force-pushed
the
14.0-split_shopinvader_v1_product
branch
from
ba24e6e
to
fbf0de4
Compare
matthieusaison
force-pushed
the
14.0-split_shopinvader_v1_product
branch
from
8159d58
to
6d3ed9e
Compare
|
Yes it's wanted, the variant case is now handle
in shopinvader_product_binding, because the class ShopinvaderVariant has
moved here too.
https://github.com/shopinvader/odoo-shopinvader/blob/6d3ed9e88adb1f6e718184dba1fd37506a690de8/shopinvader_product_binding/services/abstract_sale.py#L33
Le lun. 18 sept. 2023 à 17:40, Marie Lejeune ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In shopinvader_restapi/services/abstract_sale.py
<#1382 (comment)>
:
> @@ -43,27 +43,14 @@ def _convert_step(self, sale):
def _is_item(self, line):
return True
+ def _get_product_information(self, line):
+ return {"id": line.product_id.id}
Before, due to the shopinvader product variant, we got all info about a
product inside the SO data (product name, prices, + various custom
fields...). Now I see that we just get the product ID. Is it wanted? What
are the benefits?
—
Reply to this email directly, view it on GitHub
<#1382 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5CI2NJ6AMSSISR4ILDKDQTX3BTPVANCNFSM6AAAAAAZ4EY2WM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Resolves #1372