16.0 add shopinvader_api_sale

[sebastienbeau]

Work in progress

• add BaseSale schema (can be used by cart and sale)
• add module shopinvader_api_sale
• change the structure of the cart (TO DISCUSS)

@lmignon @sbidoul @thibaultrey

[lmignon]

IMO, a good practice is to always import defined models a module root. It eases code readability....

from odoo.addons.shopinvader_schema_sale.schemas import InvoicingInfo

[sebastienbeau]

thanks for the tips

[sebastienbeau]

@lmignon I have a weird error with the PagedCollection and I don't know why, do you have an idea?

https://github.com/shopinvader/odoo-shopinvader/actions/runs/6450464419/job/17509863251?pr=1421#step:8:203

[lmignon]

@lmignon I have a weird error with the PagedCollection and I don't know why, do you have an idea?

https://github.com/shopinvader/odoo-shopinvader/actions/runs/6450464419/job/17509863251?pr=1421#step:8:203

@sebastienbeau Don't worry. It's just because you're mixing an extendable model Sale with a bare pydantic generic model PagedCollection...

I made a little test by defining the PagedCollection mode as follows

from typing import TypeVar, List, Generic
from odoo.addons.extendable_fastapi.schemas import StrictExtendableBaseModel

T = TypeVar("T")


class PagedCollection(StrictExtendableBaseModel, Generic[T]):
    total: int
    items: List[T]

and it works

I propose to add these generics models into the odoo.addons.extendable_fastapi.schemas module. I'll keep you informed once it's done.

[lmignon]

@sebastienbeau here it's OCA/rest-framework#380

[sebastienbeau]

Regarding the security rule define here :
https://github.com/shopinvader/odoo-shopinvader/tree/16.0/shopinvader_api_cart/security

We need to define the same rule on api_sale, api_quotation, api_cart (we want to show the sale that belong to the authenticated_partner)

I see 3 possibility

1. api_quotation, api_cart depend on api_sale (because you never will have a cart (and quotation) without sale history, and if you have the case, you still can not mount the endpoint "sales")
2. we duplicate the rule and make them more accurate (by adding the typology on the rule), so the group cart only return cart. Note we also need in each api (cart, quotation, sale to filter on the right typo, so a cart can not read from sale endpoint)
3. we create a base module api_sale_base that add the rule

[sebastienbeau]

There is also some "common" code for testing between the api_sale, api_quotation, api_cart

[sebastienbeau]

@lmignon the api is ready.
We just need to decide for the rule, so I can change the dependency, and update the test

[sebastienbeau]

Note: I have used the "self.model_dump(exclude_unset=True)" here to be able to support partial update

The API should be able to only push the invoicing info or the note, without needing to send every value

[lmignon]

@sebastienbeau It's a valid and appropriate use. The most important here is that you use the result of the call to model_dump to create the result of the convert_to_sale_write method but not as result of the method.

[sebastienbeau]

after merging api_address #1425

clean I will add this clean here akretion#8

[lmignon]

Thank you @sebastienbeau It's promising and easy to read. My remaining concerns:

• Not comfortable with the definition of FilteredDomainAdapter into the fastapi addon (Could be also renamed FilteredModelAdapter???)
• Do we've to put the logic to transform a schema into an odoo model dict or a domain into the schema? I've no clear args in favor or against?

Some little comments

[lmignon]

Suggested change

	def adapter(self):
	def filtered_model(self):

[lmignon]

@sebastienbeau Here it's some fixes and improvements... akretion#9

[sebastienbeau]

@lmignon I have a weird issue on the test
If you install "shopinvader_api_cart" and run

odoo -i shopinvader_schema_sale --stop-after-init --test-enable

It fail on module shopinvader_api_cart

If you run

odoo -i shopinvader_api_cart --stop-after-init --test-enable

It's work

Seem there is an issue in "extendable"

[lmignon]

/ocabot merge minor

[shopinvader-git-bot]

@lmignon The merge process could not start, because of exception [Errno 13] Permission denied: '/app/run/.cache/oca-mqt'.

[sebastienbeau]

/ocabot merge minor

[shopinvader-git-bot]

@sebastienbeau The merge process could not start, because of exception [Errno 13] Permission denied: '/app/run/.cache/oca-mqt'.

[sbidoul]

/ocabot merge minor

[shopinvader-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1421-by-sbidoul-bump-minor, awaiting test results.

[shopinvader-git-bot]

Congratulations, your PR was merged at b42cf29. Thanks a lot for contributing to shopinvader. ❤️