[16.0][FIX] shopinvader_search_engine: Fix categories into products #1480
Conversation
lmignon
commented
Nov 30, 2023
•
lmignon
commented
- Improve perfs?
lmignon
force-pushed
the
16.0-fix-catagories-compute
branch
from
3bae618
to
c0fd942
Compare
| @@ -16,3 +16,25 @@ def _filter_by_index(self): | |||
| in rec.se_binding_ids.mapped("index_id").ids | |||
| ) | |||
| return records | |||
|
|
|||
| def _filter_by_bound_in_same_lang(self): | |||
There was a problem hiding this comment.
Could you please explain why, while working on a particular index, you would need to return records linked to another index (with the same backend and lang) ?
There was a problem hiding this comment.
when you serialize a product, you also serialize categories linked to the product. In this case, you're working with the product's index not the one from the category. If you add tests to check that the categories field is filled into the product information, you'll see that before this change it was always empty.
There was a problem hiding this comment.
There was a test, but it was wrong. I've corrected it (+ added one for the lang case).
I have also opened OCA/search-engine#177 to avoid such mistakes in the future.
qgroulard
force-pushed
the
16.0-fix-catagories-compute
branch
from
d6b8443
to
0812508
Compare
lmignon
force-pushed
the
16.0-fix-catagories-compute
branch
from
0812508
to
4efaa94
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 458b51a. Thanks a lot for contributing to shopinvader. ❤️ |
