updated error controller to better handle HTTP400

[li-sui]

added IllegalArgumentException in the list, Generally, any error due to inputs should be a 400, HTTP 500 is for logic error.
updated com.salesmanager.shop.store.controller.error.ShopErrorController. now it also handles errors from com.salesmanager.shop.controller.*

Closed #646
related to #638

[JustFlavi]

I'm afraid that handling any IllegalArgumentException as a HTTP 400 is a little bit too optimistic.
IllegalArgumentExceptions are not exclusively bound to invalid user input. As a general Java standard exception, they are widely used in several APIs.
So it might happen, that while we do some internal server processing (like database access or object conversion), we call an (internal) API incorrectly and run into an IllegalArgumentException. Such a scenario would clearly be an internal issue, where a HTTP 400 would be misleading.

[li-sui]

I'm afraid that handling any IllegalArgumentException as a HTTP 400 is a little bit too optimistic. IllegalArgumentExceptions are not exclusively bound to invalid user input. As a general Java standard exception, they are widely used in several APIs. So it might happen, that while we do some internal server processing (like database access or object conversion), we call an (internal) API incorrectly and run into an IllegalArgumentException. Such a scenario would clearly be an internal issue, where a HTTP 400 would be misleading.

Yes, you are right. I will push a new commit to exclude IllegalArgumentException. I think it is still worth merging this as com.salesmanager.shop.store.controller.error.ShopErrorController has not been updated with 400 and errors under com.salesmanager.shop.controller.* has not been handled.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[JustFlavi]

Yes, you are right. I will push a new commit to exclude IllegalArgumentException. I think it is still worth merging this as com.salesmanager.shop.store.controller.error.ShopErrorController has not been updated with 400 and errors under com.salesmanager.shop.controller.* has not been handled.

Sounds good, thank you :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information