Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phones.py to add regex for Bangladesh #2

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Updated phones.py to add regex for Bangladesh #2

merged 2 commits into from
Jun 30, 2017

Conversation

shoumikchow
Copy link
Contributor

No description provided.

@shopnilsazal
Copy link
Owner

Hi,
I am sorry for late reply. I think that will be more like bn-BD not en-BD. And can you please add some tests in tests/test_phones.py? Thanks.

@shoumikchow
Copy link
Contributor Author

@shopnilsazal Made the changes you suggested!

@shopnilsazal shopnilsazal merged commit dee3da7 into shopnilsazal:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoumikchow @shopnilsazal