Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable to "last_name" and "gender" columns in customer migration #129

Closed
wants to merge 1 commit into from

Conversation

iagobruno
Copy link

For Postgres don't complain about non-null columns.

image

@gabolera
Copy link

gabolera commented Jun 9, 2022

this PR solve 2 bugs on execute php artisan shopper:admin because columns "first_name" and "gender" that not defined with nullable

is this has identical discussion in #104

Untitled

@mckenziearts please analyse this PR

thanks :)

@mckenziearts
Copy link
Collaborator

This PR cannot be valid. You had to write a new migration to fix this problem, and moreover the first_name field is nullable by default so it is last_name that I use in my views so it cannot be nullable.

Those who have already installed and used shopper will not have this modification applied since their site will already be online and the project already functional

And for the gender I will publish an Enum to avoid the problem with postgre in the next version.

If you want to correct or propose a solution you can make a PR that is structured this way. I'll close it until I get another proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants