Fix client version and add user agent platform info #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna add the solution for #61 |
ddattee
changed the title
ddattee
changed the title
ronan-gloo
reviewed
Oct 11, 2018
src/Client/ClientOptions.php
Outdated
| */ | ||
| public function setUserAgentDetails($plateform, $version) | ||
| { | ||
| $this->headers['User-Agent'] .= " ($plateform;$version)"; |
There was a problem hiding this comment.
This will not supports updates (calling the method more than once)
John-Dormevil
approved these changes
Oct 15, 2018
ronan-gloo
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the issue
This resolves #60 #61
Reason for this PR
The version returned by the client is not the one tagged in the repository.
We needed to add some informations on the platform using the SDK to help integration and debug.
What does the PR do
Sync the version with the repo.
Allow to add platform information to SDK user agent.
How to test
On the client when calling
Client::VERSIONthe version returned should be 0.2.4.When setting
userAgentDetailsinformations onClientOptionsall call made by the SDK should contain the platform used and its version