Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfering items from shopping cart for just logged in customer is not working #588

Closed
dzarda86 opened this issue Nov 12, 2018 · 1 comment · Fixed by #640
Closed

Transfering items from shopping cart for just logged in customer is not working #588

dzarda86 opened this issue Nov 12, 2018 · 1 comment · Fixed by #640
Assignees
@LukasHeinz
Labels
Enhancement New feature or request for change from user point of view

Comments

@dzarda86
Copy link
Contributor

Unregistered user's items of shopping cart are not merged into new shopping cart of justlogged in customer.

What is happening

I am using Shopsys 7.0.0.beta1

  1. As an unregistered user I add few items into my shopping cart
  2. I log in into my account (lets say just registered)
  3. Items from my shopping cart are gone

--
4) After logging out they are back again

--

Hint: CartMigrationFacade ->mergeCurrentCartWithCart is triggered only after logout. It is not triggered after login (i am using LoginService->loginUser() method)
@LukasHeinz LukasHeinz self-assigned this Nov 14, 2018
@LukasHeinz LukasHeinz added the Enhancement New feature or request for change from user point of view label Nov 14, 2018
@vitek-rostislav
Copy link
Contributor

We discussed this on Slack with @dzarda86, there is a problem that user's session ID is not changed after login, therefore the condition $previousCartIdentifier !== $session->getId() in CartMigrationFacade does not pass, hence the cart is not migrated. The solution might be migrating session using $request->getSession()->migrate() in LoginService::loginUser().

dzarda86 added a commit to dzarda86/shopsys that referenced this issue Nov 29, 2018
@dzarda86
Solution propsal of issue shopsys#588 - Transfering items from shoppi…
87ed0a0 
…ng cart for just logged in customer is not working
@dzarda86 dzarda86 mentioned this issue Nov 29, 2018
Merged
dzarda86 added a commit to dzarda86/shopsys that referenced this issue Nov 29, 2018
@dzarda86
Solution propsal of issue shopsys#588 - Transfering items from shoppi…
e80bf16 
…ng cart for just logged in customer is not working
grossmannmartin added a commit that referenced this issue Dec 7, 2018
@grossmannmartin
fixup! Solution propsal of issue #588 - Transfering items from shoppi…
e4a2106 
…ng cart for just logged in customer is not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasHeinz LukasHeinz

Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[framework] Fixed cart merging after login (closes #588) dzarda86/shopsys
3 participants
@vitek-rostislav @dzarda86 @LukasHeinz