This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
NEXT-28963 - Fix data handling types #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasLimberg
force-pushed
the
next-28963/fix-data-handling-types
branch
from
e989651
to
acf2e8f
Compare
seggewiss
approved these changes
Jul 6, 2023
jleifeld
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vue 3 has a problem with anything but plain objects being used as reactive values.
Our current data handling solution uses custom proxies for nearly anything. Each entity is a custom proxy object, which Vue 3 highly misadvises to use. We need to discuss possible solutions.
Solution
Remove the
privateannotation on fields of the criteria class. This is unproblematic, as TypeScript didn't enforce theprivatedeclaration and fields could have been accessed and modified before.