Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin-base-guide.md #660

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Update plugin-base-guide.md #660

merged 2 commits into from
Aug 17, 2022

Conversation

zaifastafa
Copy link
Contributor

Fixes #518

@Christian-Rades Christian-Rades added the Improvement PR created to append/modify info in the existing article label Aug 17, 2022
Christian-Rades
Christian-Rades suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@Christian-Rades Christian-Rades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We require our code blocks to specify a language. Once that is done, we can merge your PR.

guides/plugins/plugins/plugin-base-guide.md Outdated Show resolved Hide resolved
@zaifastafa @Christian-Rades
Add language in code block
09762cc 
Co-authored-by: Christian Rades <christian.rades@googlemail.com>
@Christian-Rades Christian-Rades merged commit 2175d66 into shopware:master Aug 17, 2022
@zaifastafa zaifastafa deleted the patch-1 branch August 17, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-Rades Christian-Rades Christian-Rades approved these changes

Assignees
No one assigned
Labels
Improvement PR created to append/modify info in the existing article
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin:create nowhere to be seen in the "Plugin Base Guide"
2 participants
@zaifastafa @Christian-Rades