Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change request api version to latest #18

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

jleifeld
Copy link
Contributor

No description provided.

@klarstil
Copy link
Contributor

klarstil commented Apr 17, 2020

Personally I'm not a big fan of changing the API version this many times. We can't ensure the project which uses this package supports the hardcoded API version. As a proposal to solve the problem we should come up with an environment / config variable which contains the API version the test platform should use.

This way the project which uses this package can define the version they would like to use instead of constantly bumping up the API version in the URLs itself.

See:

@jleifeld jleifeld force-pushed the change-api-version-to-general branch from d7d0291 to ad362fb Compare April 17, 2020 07:21
@leichteckig
Copy link
Contributor

I like @klarstil 's idea. 👍 In my opinion, we should consider this usage of env variables.

For better understanding, why do we want to set the API version back to v1 after all? My last information was setting it completely independent using ** notation.

@jleifeld
Copy link
Contributor Author

I set it back just for Request Calls. You can´t request the api with version **

@jleifeld
Copy link
Contributor Author

Lets create a ticket for this to build a clean solution and use this as a quickfix?

@leichteckig
Copy link
Contributor

Ah, got it. We'll take this PR as quick fix and implement the clean solution in another ticket asap.

@leichteckig leichteckig merged commit b732e65 into master Apr 17, 2020
@leichteckig leichteckig deleted the change-api-version-to-general branch April 17, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants