Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr context from cookies #172

Merged
merged 2 commits into from Apr 25, 2023
Merged

fix: ssr context from cookies #172

merged 2 commits into from Apr 25, 2023

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Apr 25, 2023

Description

closes #150

  • fixed problem with context on SSR reload
  • improved performance of initial page load from demo store, as context no longer needs to reload before wishlist
  • lighthouse score should go up as we're having less reqyests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Not logged-in customer at homepage

Before:
image
After:
image

Logged in customer at homepage

Before:
image

After:
image

Additional context

I had a lot of items in wishlist so added clearWishlist button
image

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 11:40am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 11:40am

@patzick patzick merged commit 4b323a1 into main Apr 25, 2023
11 checks passed
@patzick patzick deleted the fix/ssr-contex-from-cookies branch April 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Refreshing page when changing data in my account
1 participant