New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: override components and composables #452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… schema overrides
patzick
changed the title
feat!: overwrite components and composables
feat!: override components and composables
Nov 14, 2023
Co-authored-by: Maciek Kucmus <mkucmus@users.noreply.github.com>
mkucmus
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like a christmas gift 🎅
1 task
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Info: signature breaking change: means that these changes might be breaking and require some migration steps on the project side
composables
andcms-base
packages from nuxt modules to nuxt layers - up to discussion if we want to introduce it as separate packages not to have breaking chane. Braking change would be very minor - 2 lines in nuxt config file.composables
package to export layer module withnuxt.config.ts
as main file, built version with no possibility to override) is accessible under/dist
for now (added as discussion point below)#imports
with all dynamicPR changes to finish
import {} from "#imports"
import type { Schemas } from "#shopware"
types
definitions with imports from#shopware
to ensure that types comes from API, add deprecation message on types intypes
package. This can help avoid breaking change and allow for smoother transition towards new types definitionscomposables
package, currently it’simport type { SliderElementConfig } from "@shopware-pwa/composables-next/composables";
_useContext
composable asuseContext
in packageIssues to create after this PR
helpers
to use generic types instead oftypes
types
package usage and progress with deprecation and removal processThings to consider and decide
/composables/**dist**