Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): i18n module upgrade for vue-demo-store #514

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Dec 19, 2023

Description

Upgrades @nuxjs/i18n module to the latest rc.11 version.

  • removes JIT warning (compile.jit: false config is not required anymore)
  • jsTsFormatResource optional config is not required anymore to read translations properly from .ts files

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jan 3, 2024 2:59am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jan 3, 2024 2:59am

@mkucmus
Copy link
Collaborator Author

mkucmus commented Dec 19, 2023

@kstala please have a look also on translations within CMS elements imported from cms-base package. I think the problem might be general and we need to find out how to cover the imported packages with dynamic translations coming from app context (nuxt app). If it's not working only in regards to this changes (check also the canary version to compare), please create a ticket with the details.

@mdanilowicz
Copy link
Collaborator

mdanilowicz commented Dec 22, 2023

Screenshot 2023-12-22 at 10 45 41
Screenshot 2023-12-22 at 10 54 38

Not everything is translated. Can you add the missing translations? Or check why it is not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants