Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-demo): JSON-LD example #531

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat(vue-demo): JSON-LD example #531

merged 5 commits into from
Jan 30, 2024

Conversation

mdanilowicz
Copy link
Collaborator

Description

closes #530

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jan 30, 2024 10:11am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jan 30, 2024 10:11am

@BrocksiNet
Copy link
Collaborator

I like this PR a lot. Thx. 👍

Only two comments:

  • Description has HTML inside and should only be text
  • With JSON LD you can have multiple entries. Not only Product. A classic example would be Product + Breadcrumb in JSON LD. Should our small example support that possibility?

Also nice reference here.

@mdanilowicz
Copy link
Collaborator Author

I like this PR a lot. Thx. 👍

Only two comments:

  • Description has HTML inside and should only be text
  • With JSON LD you can have multiple entries. Not only Product. A classic example would be Product + Breadcrumb in JSON LD. Should our small example support that possibility?

Also nice reference here.

Ok I removed tags.
Regarding the breadcrumbs, there are no links in response so we should wait for the #139

The main goal of this task is to show - HOW. That is why there is a possibility of overriding the JSON by the additional param. Also, this is a template composable, so each app should have its own implementation of it.

@BrocksiNet
Copy link
Collaborator

Sure, we can also create a follow-up issue after merging this PR.
To improve the example when breadcrumbs are done. Like it. 👍

@BrocksiNet BrocksiNet self-requested a review January 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] How to use JSON-LD
3 participants