Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-demo-store): visibility classes #545

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

itscark
Copy link
Contributor

@itscark itscark commented Jan 29, 2024

Description

Fixes element visibility.

Type of change

Bug fix (non-breaking change that fixes an issue)

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jan 29, 2024 8:00pm

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! 🙌
I added tests for that and follow up in #549 to export all classes and simplify adding it in theme.

@patzick patzick merged commit 6664aa2 into shopware:main Jan 29, 2024
6 checks passed
BrocksiNet pushed a commit that referenced this pull request Feb 20, 2024
* fix(helpers): visibility css classes

* fix(vue-demo-store): add visibility classes to safe list

* chore: generate changeset

* chore: improve code, add tests and fix linter error

---------

Co-authored-by: Marc Peternell <marc.peternell@iwavesmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants