Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client): provide optional credentials field for automatic authentication #560

Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Feb 2, 2024

Description

closes: #553

Type of change

Replaced additional only token-based clientData with optional credentials` field.

This way, scripts or apps can provide admin authentication of their choice to be used automatically before invoking any endpoint.

@patzick patzick requested a review from mkucmus February 2, 2024 13:13
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Feb 2, 2024 1:14pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Feb 2, 2024 1:14pm

Copy link

codspeed-hq bot commented Feb 2, 2024

CodSpeed Performance Report

Merging #560 will not alter performance

Comparing feat/provide-default-credentials-for-admin-api-client (ed372fd) with main (97d2859)

Summary

✅ 9 untouched benchmarks

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] api-next: allow passing directly the oauth credentials instead of session data
2 participants