Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composables): b2b quote management #703

Merged
merged 4 commits into from
Mar 4, 2024
Merged

feat(composables): b2b quote management #703

merged 4 commits into from
Mar 4, 2024

Conversation

mdanilowicz
Copy link
Collaborator

Description

Will unlock #699

Type of change

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Mar 4, 2024 5:57pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Mar 4, 2024 5:57pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 4, 2024 •
edited

CodSpeed Performance Report

Merging #703 will improve performances by ×21

Comparing feat/GH-543-composable (06f2a75) with main (24b42e1)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/GH-543-composable Change
⚡ [api-client][transformPathToQuery] - transform without any params 6,227.1 µs 300 µs ×21

patzick
patzick requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small improvements for internal api

packages/composables/src/useB2bQuoteManagement.ts Outdated Show resolved Hide resolved
packages/composables/src/useB2bQuoteManagement.ts Outdated Show resolved Hide resolved
packages/composables/src/useB2bQuoteManagement.ts Outdated Show resolved Hide resolved
packages/composables/src/useB2bQuoteManagement.ts Outdated Show resolved Hide resolved
@patzick patzick merged commit 7a3a92c into main Mar 4, 2024
12 checks passed
@patzick patzick deleted the feat/GH-543-composable branch March 4, 2024 18:12
This was referenced Mar 5, 2024
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Open
@github-actions github-actions bot mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdanilowicz @patzick