Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cms): add 3d media support #794

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat(cms): add 3d media support #794

merged 5 commits into from
Apr 18, 2024

Conversation

mdanilowicz
Copy link
Collaborator

@mdanilowicz mdanilowicz commented Mar 23, 2024

Description

closes #748

Product link https://frontends-demo-git-feat-gh-748-shopware-frontends.vercel.app/detail/018e4c8adc0d70c3a0eff2040765c82e

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Apr 18, 2024 11:12am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Apr 18, 2024 11:12am

Copy link

codspeed-hq bot commented Mar 23, 2024

CodSpeed Performance Report

Merging #794 will not alter performance

Comparing feat/GH-748 (f4f23a6) with main (c605489)

Summary

✅ 9 untouched benchmarks

@BrocksiNet
Copy link
Collaborator

How to know on which product the 3D model is placed or where to test (without searching via Admin).
Description is very incomplete 😿

@patzick patzick added the blocked label Apr 5, 2024
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!
Only one minor issue to solve - lazy loading component, to not include threejs library in every image component

@patzick patzick merged commit ead7415 into main Apr 18, 2024
13 checks passed
@patzick patzick deleted the feat/GH-748 branch April 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Spatial commerce support
4 participants