-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Reactivates foreign key checks after import database. #1422
BUGFIX: Reactivates foreign key checks after import database. #1422
Conversation
Hey @mjosef89, thanks for your contribution. Could you please add a changelog file? |
0d1509b
to
7ed1896
Compare
Done. I hope this is still correct. |
@mjosef89 fyi, you are only allowed to use the headers that are listed there. The correct one would be 'Core'. I'll change that for you. |
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
Hey @mjosef89, thanks for your contribution 💙 |
1. Why is this change necessary?
Avoid problems e.g. when swaping the default language to german.
2. What does this change do, exactly?
Reactivates foreign key checks after import database in CLI mode.
3. Describe each step to reproduce the issue or behaviour.
Run the following command:
Before bugfix
In table
language
the entry "Deutsch" has the correct default id "2fbb5fe2e29a4d70aa5854ce7ce3e20b".But because foreign key checks were disabled all
language.id
references are faulty.For example in
country_translation
all english entries still reference the "2fbb5fe2e29a4d70aa5854ce7ce3e20b"language_id that is now german and the german entries refer to a language_id that no longer exists.
After bugfix
All references to language.id are now correctly adjusted.
5. Checklist