Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields in category entity #281

Closed
wants to merge 5 commits into from
Closed

Custom fields in category entity #281

wants to merge 5 commits into from

Conversation

PheysX
Copy link
Contributor

@PheysX PheysX commented Nov 10, 2019

1. Why is this change necessary?

At the moment, its not possible to create custom fields for the category entity.

2. What does this change do, exactly?

  • Added custom field twig template and js logic to the shopware component sw-category
  • Added the category to the entityNameStore in the custom-field.service

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

#278

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@raknison
Copy link

Hi, @PheysX.
Thank you for your contribution. I will check you PR soon.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-5505

Please use this issue to track the state of your pull request.

@raknison
Copy link

Hi @PheysX,

could you rebase your pull request and squash your commits please.
We made some changes to the file structure.

Thank you!

@mitelg
Copy link
Member

mitelg commented Nov 21, 2019

thanks for your contribution @PheysX 👍 🎉 💙

@PheysX
Copy link
Contributor Author

PheysX commented Nov 21, 2019

Thanks for restructure my commits <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants