Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-8592 - Change Customer Password #922

Merged

Conversation

wexotk
Copy link
Contributor

@wexotk wexotk commented May 14, 2020

1. Why is this change necessary?

Fix for issue #879

2. What does this change do, exactly?

  • First commit allows you to change a customers password from the admin page.
  • The second commit allows you to change the password of an admin user through the Settings -> Users & Permissions (instead of Your Profile). For now it only allows you to change your own password, but when admin roles gets added, it'll be easy to add so a super admin can change other admins passwords too.

3. Describe each step to reproduce the issue or behaviour.

If you go to the customer list, click on a customer and click edit. It should now show two more input fields, "new password" and "confirm new password". If both are equal and above 0 characters (you should probably add some password requirements for future reference), the password will be changed on the user. If the fields doesn't match, an error message will be shown.
Furthermore a success message for when editing a user has been added.

4. Please link to the relevant issues (if any).

#879

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@Phil23 Phil23 changed the title Next 85992 change customer password NEXT-8592 - Change Customer Password May 14, 2020
@raknison raknison self-requested a review May 15, 2020 07:50
Copy link

@raknison raknison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and add Fixes #879 to the message to auto-close this issue.

Copy link

@raknison raknison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description to theCHANGELOG-6.2.md about your additions/changes.

@wexotk wexotk closed this May 15, 2020
@wexotk wexotk deleted the NEXT-85992_change_customer_password branch May 15, 2020 08:18
@wexotk wexotk restored the NEXT-85992_change_customer_password branch May 15, 2020 08:38
@wexotk wexotk deleted the NEXT-85992_change_customer_password branch May 15, 2020 08:39
@wexotk wexotk restored the NEXT-85992_change_customer_password branch May 15, 2020 08:47
@wexotk wexotk reopened this May 15, 2020
@wexotk wexotk force-pushed the NEXT-85992_change_customer_password branch from 4fec971 to 4603d85 Compare May 15, 2020 08:50
@wexotk
Copy link
Contributor Author

wexotk commented May 15, 2020

@raknison Both should be fixed now, but your QA also asked for a minimum length of 8, so I'll look into that.

@pantrtxp pantrtxp removed the Declined label May 15, 2020
@wexotk wexotk force-pushed the NEXT-85992_change_customer_password branch from 564f7a4 to b435357 Compare May 15, 2020 10:38
@leichteckig
Copy link
Contributor

QA approved ✔️

@wexotk wexotk force-pushed the NEXT-85992_change_customer_password branch from 934ac17 to 26e2674 Compare May 18, 2020 07:23
@raknison raknison merged commit 47a4791 into shopware:6.2-BoostDay May 18, 2020
@raknison
Copy link

Thanks for your Contribution! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants