Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong node version requirement? #14

Closed
didi-at-work opened this issue Feb 4, 2019 · 1 comment
Closed

Wrong node version requirement? #14

didi-at-work opened this issue Feb 4, 2019 · 1 comment
Assignees
@klarstil

Comments

@didi-at-work
Copy link

https://github.com/shopware/platform/blob/80a5bf385d312946361ea607b04bc1d700c9b48f/src/Administration/Resources/administration/package.json#L130

Trying to build with node 8.14.0 this exits out with an error. Shouldn't the line read
"node": ">=6.14.0 || >=8.10.0 || >=9.10.0",
?
@klarstil
Copy link

klarstil commented Feb 5, 2019

Hey @didi-at-work,
you're right, the version isn't matching correctly. Thanks for pointing it out 👍 I'll create a PR in a few and will fix it.
Best regards

@klarstil klarstil self-assigned this Feb 5, 2019
shopwareBot pushed a commit that referenced this issue Feb 5, 2019
@tobiasberge
Merge pull request #1042 in NEXT/platform from ntr/master/fixed-node-…
5fcbd38 
…version-recommendation to master

* commit '6c422883e3f11bbcab03795fa88ef7ffef5a44fd':
  NTR - Fixed wrong node.js version recommendation. Fixes #14
shopwareBot pushed a commit to shopware/administration that referenced this issue Feb 5, 2019
NTR - Fixed wrong node.js version recommendation. Fixes shopware/shop…
edcd3ed 
…ware#14
@flo2000ace flo2000ace mentioned this issue Oct 24, 2019
Closed
@gummipunkt gummipunkt mentioned this issue Jun 30, 2021
Closed
@xUJYx xUJYx mentioned this issue Feb 18, 2022
Open
@wexotht wexotht mentioned this issue Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klarstil klarstil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klarstil @didi-at-work