Control settings "None" on image sliders don't work

[phit]

PHP Version

N/A

Shopware Version

trunk 75ae67f

Expected behaviour

setting navigation arrows or dots for image slider or image gallery to none disables the controls

Actual behaviour

the arrows/dots stay and are no longer positioned correctly

How to reproduce

shopware/src/Storefront/Resources/views/storefront/element/cms-element-image-gallery.html.twig

Line 18 in 75ae67f

{% set navigationArrows = sliderConfig.navigationArrows.value %}

shopware/src/Storefront/Resources/views/storefront/element/cms-element-image-slider.html.twig

Line 13 in 75ae67f

controls: sliderConfig.navigationArrows.value ? true : false,

All the output templates expect that selecting "None" sets the value to a falsey value or more specfically null.

But the settings in the administration appear to be broken, these should all be using :modelValue

shopware/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-slider/config/sw-cms-el-config-image-slider.html.twig

Lines 152 to 154 in 75ae67f

	<option :value="null">
	{{ $tc('sw-cms.elements.imageSlider.config.label.navigationPositionNone') }}
	</option>

shopware/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-gallery/config/sw-cms-el-config-image-gallery.html.twig

Lines 206 to 208 in 75ae67f

	<option :value="null">
	{{ $tc('sw-cms.elements.imageSlider.config.label.navigationPositionNone') }}
	</option>

[shopware-issue-bot]

We found the following existing issues which may help or are related to your topic:

• fix image slider config
• CMS image slider settings broken
• Slider dots are not visible when config is set to "outside"
• Safari image slider does not work
• Fixing CMS Image sliders when arrows are outside
• Missing CMS Image Slider Snippet
• Image Slider / Image Gallery do not show images after save
• Image Slider / Image Gallery do not show images after save
• CMS Imageslider settings tab not working
• [GitHub] Fixing CMS Image sliders when arrows are outside

[mitelg]

seems to be a similar issue: #3641