Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CMS Image sliders when arrows are outside #2731

Closed

Conversation

NinjaArmy
Copy link
Contributor

@NinjaArmy NinjaArmy commented Oct 5, 2022

1. Why is this change necessary?

If you create an image slider or an gallery slider in the shopping experiences and set the navigation arrows to outside, you will see a part of the next and a part of the previous slide under the control arrows.
image

2. What does this change do, exactly?

Correcting the display of the cms image slider when the control arrows are outside. Added a bit css and a wrapper div to place the arrows at the correct position.

3. Describe each step to reproduce the issue or behaviour.

Go the the shopping experience and create a new layout. Drag and drop the image slider or the image gallery element into the layout and add a couple of images. Go to the configuration of the element and choose the outside option for the control arrows. Now take a look at the storefront and you should see the styling Issue. On the left and right side of the active slide image you see a part of the next and previous slide.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2731 (d3e3063) into trunk (1582aa7) will increase coverage by 0.50%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##            trunk    #2731      +/-   ##
==========================================
+ Coverage   65.29%   65.79%   +0.50%     
==========================================
  Files        3616     3648      +32     
  Lines       80784    81483     +699     
==========================================
+ Hits        52748    53613     +865     
+ Misses      28036    27870     -166     
Impacted Files Coverage Δ
...ent/Product/SearchKeyword/ProductSearchBuilder.php 89.28% <ø> (ø)
...ork/DataAbstractionLayer/Dbal/JoinGroupBuilder.php 95.77% <ø> (-0.06%) ⬇️
...earch/Exception/ElasticsearchIndexingException.php 100.00% <ø> (ø)
...rc/Elasticsearch/Framework/ElasticsearchHelper.php 80.89% <ø> (ø)
...tractionLayer/Dbal/EntityDefinitionQueryHelper.php 88.76% <75.00%> (-0.50%) ⬇️
...search/Framework/Indexing/ElasticsearchIndexer.php 99.40% <98.41%> (+17.64%) ⬆️
src/Core/Checkout/Cart/Price/Struct/CartPrice.php 89.47% <100.00%> (ø)
...rc/Core/Checkout/Cart/Tax/Struct/CalculatedTax.php 100.00% <100.00%> (ø)
...eckout/Cart/Tax/Struct/CalculatedTaxCollection.php 82.75% <100.00%> (ø)
...uct/SearchKeyword/ProductSearchKeywordAnalyzer.php 87.50% <100.00%> (+2.31%) ⬆️
... and 287 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23928

Please use this issue to track the state of your pull request.

@raknison raknison added the hacktoberfest-accepted PR is accepted by us for Hacktoberfest label Oct 28, 2022
@mstegmeyer
Copy link
Contributor

Your PR has been merged. We made some alterations and moved the changes completely to CSS. Thank you for your contribution 💙🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted hacktoberfest-accepted PR is accepted by us for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants