Quote JSON path segments for query accessor. #1488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Usage of hyphenated fields in JSON fields in a DAL query currently results in a MySQL error "Invalid JSON path expression". Such fields must be quoted to be used in a query.
2. What does this change do, exactly?
It quotes all segments (separated by
.
) when building the field accessor for the MySQL query.3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
There's no issue yet, as far as I can tell.
5. Checklist