-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort price collection by price #2442
Conversation
9ae07c0
to
dc41884
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #2442 +/- ##
=======================================
Coverage 62.68% 62.69%
=======================================
Files 3414 3414
Lines 73963 73967 +4
=======================================
+ Hits 46362 46371 +9
+ Misses 27601 27596 -5
Continue to review full report at Codecov.
|
src/Core/Content/Product/Aggregate/ProductPrice/ProductPriceCollection.php
Outdated
Show resolved
Hide resolved
src/Core/Content/Product/Aggregate/ProductPrice/ProductPriceCollection.php
Outdated
Show resolved
Hide resolved
src/Core/Content/Product/Aggregate/ProductPrice/ProductPriceCollection.php
Outdated
Show resolved
Hide resolved
src/Core/Content/Product/Aggregate/ProductPrice/ProductPriceCollection.php
Show resolved
Hide resolved
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
Hey @zaifastafa thanks again for your contribution! 🎉 💙 Your changes were merged. |
1. Why is this change necessary?
Just a helper method to sort product prices by price. Similar to the sortByQuantity method.
2. What does this change do, exactly?
Adds a helper method to the collection to sort it by prices.
5. Checklist