Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort price collection by price #2442

Closed
wants to merge 4 commits into from

Conversation

zaifastafa
Copy link
Contributor

@zaifastafa zaifastafa commented Apr 25, 2022

1. Why is this change necessary?

Just a helper method to sort product prices by price. Similar to the sortByQuantity method.

2. What does this change do, exactly?

Adds a helper method to the collection to sort it by prices.

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have read the contribution requirements and fulfil them.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2442 (1b7791b) into trunk (ea35c69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            trunk    #2442   +/-   ##
=======================================
  Coverage   62.68%   62.69%           
=======================================
  Files        3414     3414           
  Lines       73963    73967    +4     
=======================================
+ Hits        46362    46371    +9     
+ Misses      27601    27596    -5     
Impacted Files Coverage Δ
.../Aggregate/ProductPrice/ProductPriceCollection.php 90.00% <100.00%> (+6.66%) ⬆️
...c/Storefront/Theme/Subscriber/UpdateSubscriber.php 84.21% <0.00%> (-5.27%) ⬇️
...Core/Content/Category/Service/NavigationLoader.php 97.05% <0.00%> (-2.95%) ⬇️
...ataAbstractionLayer/DefinitionInstanceRegistry.php 91.07% <0.00%> (-1.79%) ⬇️
...torefront/Framework/Twig/TemplateDataExtension.php 97.95% <0.00%> (ø)
...bstractionLayer/Write/EntityWriteResultFactory.php 91.03% <0.00%> (+0.04%) ⬆️
...FieldSerializer/PriceDefinitionFieldSerializer.php 67.21% <0.00%> (+0.54%) ⬆️
...nistration/Controller/AdministrationController.php 59.00% <0.00%> (+0.58%) ⬆️
...out/Promotion/Cart/PromotionDeliveryCalculator.php 82.55% <0.00%> (+1.16%) ⬆️
...yer/CheapestPrice/CheapestPriceAccessorBuilder.php 77.55% <0.00%> (+1.55%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea35c69...1b7791b. Read the comment docs.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-21319

Please use this issue to track the state of your pull request.

@zaifastafa zaifastafa deleted the zaifastafa-patch-1 branch April 29, 2022 11:43
@keulinho
Copy link
Contributor

Hey @zaifastafa thanks again for your contribution! 🎉 💙 Your changes were merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants