Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-36283 - Add names and company of addresses to customer admin es search index #3721

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented May 17, 2024

1. Why is this change necessary?

When searching in customers for a term that only exists in the first_name, last_name, or company of the address of a customer, the ES admin search does not find the customer. But when clicking “Show all results in customer view”, the customer gets displayed.

2. What does this change do, exactly?

It adds first_name, last_name, and company of table customer_address to customer admin ES search index

3. Describe each step to reproduce the issue or behavior.

  1. Have customer with a term that only exists in the field first_name, last_name, or company of an address.
  2. Search via ES admin search, no results
  3. Click on “Show all results in customer view”, customer is shown as result.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@M-arcus M-arcus force-pushed the add-elasticsearch-customer-data-to-index branch from 341d03e to 41aedc0 Compare May 21, 2024 10:38
@jozsefdamokos jozsefdamokos changed the title NEXT-00000 - Add names and company of addresses to customer admin es search index NEXT-36283 - Add names and company of addresses to customer admin es search index May 23, 2024
@jozsefdamokos jozsefdamokos self-assigned this May 23, 2024
@jozsefdamokos
Copy link
Member

@M-arcus thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants