Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend type hint to match default value #451

Closed
wants to merge 1 commit into from
+2 −10
Closed

Amend type hint to match default value #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Storefront/Controller/CmsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,14 @@ public function __construct(
* Route for cms data (used in XmlHttpRequest)
*
* @HttpCache()
* @Route("/widgets/cms/{id}", name="frontend.cms.page", methods={"GET", "POST"}, defaults={"id"=null, "XmlHttpRequest"=true})
* @Route("/widgets/cms/{id}", name="frontend.cms.page", methods={"GET", "POST"}, defaults={"XmlHttpRequest"=true})
*
* @throws InconsistentCriteriaIdsException
* @throws MissingRequestParameterException
* @throws PageNotFoundException
*/
public function page(string $id, Request $request, SalesChannelContext $salesChannelContext): Response
{
if (!$id) {
throw new MissingRequestParameterException('Parameter id missing');
}

$cmsPage = $this->cmsRoute->load($id, $request, $salesChannelContext)->getCmsPage();

return $this->renderStorefront('@Storefront/storefront/page/content/detail.html.twig', ['cmsPage' => $cmsPage]);
Expand All @@ -72,7 +68,7 @@ public function page(string $id, Request $request, SalesChannelContext $salesCha
* Route to load a cms page which assigned to the provided navigation id.
* Navigation id is required to load the slot config for the navigation
*
* @Route("/widgets/cms/navigation/{navigationId}", name="frontend.cms.navigation.page", methods={"GET", "POST"}, defaults={"navigationId"=null, "XmlHttpRequest"=true})
* @Route("/widgets/cms/navigation/{navigationId}", name="frontend.cms.navigation.page", methods={"GET", "POST"}, defaults={"XmlHttpRequest"=true})
*
* @throws CategoryNotFoundException
* @throws MissingRequestParameterException
Expand All @@ -81,10 +77,6 @@ public function page(string $id, Request $request, SalesChannelContext $salesCha
*/
public function category(string $navigationId, Request $request, SalesChannelContext $salesChannelContext): Response
{
if (!$navigationId) {
throw new MissingRequestParameterException('Parameter navigationId missing');
}

$category = $this->categoryRoute->load($navigationId, $request, $salesChannelContext)->getCategory();

if (!$category->getCmsPageId()) {
Expand Down