Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses association in AccountOverviewPageLoader search criteria #967

Conversation

bystro
Copy link
Contributor

@bystro bystro commented May 25, 2020

1. Why is this change necessary?

addresses property of a OrderrEntity is null under the /account routing(account overview).
As a result displaying addresses in the last order overview is not possible.
This PR corresponds to #866 the difference is that it has to do with a newestOrder field of AccountOverviewPage class object.

obraz

2. What does this change do, exactly?

addresses property of a OrderrEntity is not null.

3. Describe each step to reproduce the issue or behaviour.

Visit Mein Konto/Übersicht

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@bystro bystro closed this May 25, 2020
@bystro bystro reopened this May 25, 2020
@bystro bystro closed this May 25, 2020
@bystro bystro reopened this May 25, 2020
@ssltg ssltg self-assigned this May 26, 2020
@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9037

Please use this issue to track the state of your pull request.

shopwareBot pushed a commit that referenced this pull request Jun 4, 2020
@shopwareBot
Copy link

shopwareBot commented Jun 8, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Krzysztof Kubacki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bystro
Copy link
Contributor Author

bystro commented Jun 15, 2020

Hi it seems that https://issues.shopware.com/issues/NEXT-9037 has not been released in 6.2.1 version. Will it be released with 6.2.2?

@mitelg
Copy link
Member

mitelg commented Jun 15, 2020

hey @bystro
it was released, but the changelog entry is just missing

/cc @shyim

@mitelg
Copy link
Member

mitelg commented Jun 15, 2020

sorry I was wrong 🙈

your change was merged into the master branch. because you set this to the master as target.
so it will be part of Shopware 6.3

merged with d266d02

@mitelg mitelg closed this Jun 15, 2020
@mitelg mitelg added Accepted and removed Scheduled labels Jun 15, 2020
@mitelg
Copy link
Member

mitelg commented Jun 15, 2020

thanks for your contribution anyway @bystro 👍 🎉 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants