Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language / Localisation setting derived from HTTP-Header instead of preference #61

Closed
AR0x7E7 opened this issue Feb 27, 2013 · 2 comments
Closed

Language / Localisation setting derived from HTTP-Header instead of preference #61

AR0x7E7 opened this issue Feb 27, 2013 · 2 comments

Comments

@AR0x7E7
Copy link
Contributor

AR0x7E7 commented Feb 27, 2013

Hey guys,
running a shop with German localisation set under 'Basic Settings/Shop Settings/Shop/' AND choosing 'Deutsch (Deutsch)' as language at backend login page it happens to me that some Snippet components (like 'Order status' or 'Payment status') appear still in English (see below).

Bildschirmfoto 2013-02-27 um 09 01 24

However, I figuered out that this behavior is due to the HTTP Post Header Line:
Accept-Language:en-US,en;q=0.8

On the other side, when my browser sends the following Line (different System):
Accept-Language:de-DE,de;q=0.8,en-US;q=0.6,en;q=0.4

the Snippets appear in German though I choose 'English (United Kingdom)' at login (see below).

Bildschirmfoto 2013-02-27 um 09 43 36

Finally I would say that the language selection for (at least the above mentioned) Snippets is "broken", as user selection should overwrite browser default.
OliverSkroblin pushed a commit that referenced this issue Jun 7, 2013
Merge pull request #61 from feature/sw-5262-localstorage-class-cache-…
8412e46 
…component to feature/sw-4052-backend-performance-js

* commit '7377354097d21006980d6516c36096e2f8996238':
  SW-5262 - Fixed: Remove `return` value from `setStorage` to allow to bind an listener to the 'storagechange' event
  SW-5262 - Added: Class which should handle the localStorage caching on the client side
@OliverSkroblin
Copy link
Contributor

Hi,

we will verify the issue as soon as possible. You can trace the process in our public issue tracker:
http://jira.shopware.de/?ticket=SW-6745

@dnoegel
Copy link
Contributor

dnoegel commented Sep 6, 2013

Hi,

thanks for opening this issue. In order to have all issues at one place, we've decided to move the GitHub issues to our own bug tracker which can be found at http://jira.shopware.de.

Your ticket can be found at the following url:

http://jira.shopware.de/?ticket=SW-6745

@dnoegel dnoegel closed this as completed Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OliverSkroblin @dnoegel @AR0x7E7