Move referer and user agent retrieval to if-statement header #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to access the default Auth Component using
Shopware()->Auth()
before theonPreDispatchBackend
of the Auth-Plugin has been executed. The instantiation of the Auth Component usingonInitResourceAuth
andonInitResourceBackendSession
requires the$request
property to be set, which happens in theonPreDispatchBackend
method.This patch allows to use the Auth Component, at least when the referer and client checks are not executed, by retrieving the referer and user agent from the request only when the checks are enabled.
The reason for this requirement is that we need to execute our own custom
onPreDispatchBackend
method before the default handlersonPreDispatchBackend
method has been executed, because we adapted the backend login process to support preemptive HTTP Basic Authentication.Maybe there's a better solution for this specific problem, but at least this pull request increases the performance a little bit by avoiding unnecessary variable instantiation.