Fix PHPStan error in Acl component #2401
Closed
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We must add integer to the allowed types of optional $pluginID arg. Else PHPstan level 5 check fails with: ------ -------------------------------------------------------------------- Line Bootstrap/Acl.php ------ -------------------------------------------------------------------- 53 Parameter #4 $pluginID of method Shopware_Components_Acl::createResource() expects null, int given. ------ --------------------------------------------------------------------
mitelg
reviewed
Dec 13, 2020
| public function createResource( | ||
| $resourceName, | ||
| array $privileges = null, | ||
| /* @noinspection PhpUnusedParameterInspection */ $menuItemName = null, |
There was a problem hiding this comment.
Suggested change
| /* @noinspection PhpUnusedParameterInspection */ $menuItemName = null, | |
| $menuItemName = null, |
| array $privileges = null, | ||
| /* @noinspection PhpUnusedParameterInspection */ $menuItemName = null, | ||
| $pluginID = null | ||
| ){ |
| @@ -144,12 +144,14 @@ public function hasResourceInDatabase($resourceName) | |||
| * @param string $resourceName - unique identifier or resource key | |||
| * @param array|null $privileges - optionally array [a,b,c] of new privileges | |||
| * @param null $menuItemName - optionally s_core_menu.name item to link to this resource | |||
There was a problem hiding this comment.
Suggested change
| * @param null $menuItemName - optionally s_core_menu.name item to link to this resource | |
| * @param string|null $menuItemName - optionally s_core_menu.name item to link to this resource |
|
This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request. For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must add integer to the hinted types of optional $pluginID arg.
Else PHPstan level 5 check fails with:
Line Bootstrap/Acl.php
53 Parameter #4 $pluginID of method
Shopware_Components_Acl::createResource() expects null, int given.
1. Why is this change necessary?
PHPStan level 5 check in our plugin fails.
2. What does this change do, exactly?
We just add int to the hinted types of the optional $pluginID argument to createResource().
3. Describe each step to reproduce the issue or behaviour.
Use createResource(), run a PHPStan check level 5 to trigger an error like:
Line Bootstrap/Acl.php
53 Parameter #4 $pluginID of method
Shopware_Components_Acl::createResource() expects null, int given.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist