Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

NEXT-9121 - Maintenance mode finished - automatically redirect visitors from maintenance page to shop page #37

Closed
shopwareBot opened this issue Aug 7, 2020 · 2 comments
Assignees
Labels
Core Stuff in the Core (mostly PHP) Storefront Stuff in the Storefront (Mostly JS, Bootstrap & HTML)
Projects

Comments

@shopwareBot
Copy link

EN:
During maintenance mode, visitors are redirected to /maintenance. Unfortunately, these visitors are not automatically redirected to e.g. the shop start page after the end of the maintenance mode.

We would like to ask you to implement such a simple feature and to configure it in the administration area:

Redirect users to the following page after the end of the maintenance mode:
(Display of a combo box with system maintained targets, e.g. shop start page)

Shopware version: v6.2.0

Reproduction steps:

  1. activate maintenance mode
  2. visit shop -> redirection to /maintenance takes place
  3. deactivate maintenance mode

Expected result:
The visitor redirected to /maintenance is automatically redirected to the shop start page after the maintenance mode is cancelled. For this purpose, the maintenance mode status is checked periodically.

Actual result:
The visitor redirected to /maintenance is not automatically redirected to the store home page after the maintenance mode is canceled and remains on /maintenance indefinitely.

DE:
Während des Wartungsmodus werden Besucher auf /maintenance umgeleitet. Leider findet für diese Besucher nach dem Ende des Wartungsmodus keine automatische Umleitung auf z. B. die Shop-Startseite statt.

Wir möchten Euch bitten, ein solches, simples Feature umsetzen und ggf. im Administrationsbereich konfigurierbar zu schalten:

Benutzer nach Ende des Wartungsmodus auf folgende Seite umleiten:
(Anzeige einer Kombobox mit systemgepflegten Zielen, z. B. Shop-Startseite)

Shopware-Version: v6.2.0

Reproduktionsschritte:

  1. Wartungsmodus aktivieren
  2. Shop besuchen -> Umleitung auf /maintenance erfolgt
  3. Wartungsmodus deaktivieren

Erwartetes Ergebnis:
Der auf /maintenance umgeleitete Besucher wird automatisch nach Aufhebung des Wartungsmodus auf die Shop-Startseite weitergeleitet. Dazu wird der Status zum Wartungsmodus periodisch überprüft.

Tatsächliches Ergebnis:
Der auf /maintenance umgeleitete Besucher wird nach Aufhebung des Wartungsmodus nicht automatisch zur Shop-Startseite weitergeleitet und verweilt unendlich auf /maintenance.

@shopwareBot shopwareBot added Core Stuff in the Core (mostly PHP) Storefront Stuff in the Storefront (Mostly JS, Bootstrap & HTML) labels Aug 7, 2020
@pantrtxp pantrtxp changed the title NEXT-9121 - Wartungsmodus beendet - Besucher automatisch von Wartungsmodus-Seite auf Shop-Seite umleiten NEXT-9121 - Maintenance mode finished - automatically redirect visitors from maintenance page to shop page Aug 7, 2020
@tinect tinect self-assigned this Sep 16, 2020
@tinect tinect added this to In progress in BoostDay Sep 17, 2020
@tinect tinect removed this from In progress in BoostDay Sep 17, 2020
@tinect tinect added this to In progress in BoostDay Sep 17, 2020
@tinect
Copy link

tinect commented Sep 17, 2020

One specific problem is, that in the current MaintenanceController is a check for active MaintenanceMode, but it doesn't respect the Whitelist-IP.

I fixed this, and I will add an autoreload

@tinect
Copy link

tinect commented Sep 17, 2020

Damn, this implementation seems to have more bugs:

  • metaInformations missing
  • no httpCodes

@tinect tinect moved this from In progress to In Review in BoostDay Sep 17, 2020
@shyim shyim closed this as completed in c9505b4 Sep 27, 2020
BoostDay automation moved this from In Review to Done Sep 27, 2020
shyim pushed a commit that referenced this issue Sep 28, 2020
shyim pushed a commit that referenced this issue Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core Stuff in the Core (mostly PHP) Storefront Stuff in the Storefront (Mostly JS, Bootstrap & HTML)
Projects
No open projects
BoostDay
  
Done
Development

No branches or pull requests

2 participants