Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

fix bug to add category image for admin dashboard #13

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

taanguyen
Copy link

@taanguyen taanguyen commented Oct 22, 2021

Add category image to replace placeholder category image of admin dashboard

Add category image to admin dashboard. Does not yet apply the new category image to the category image on the home page.

Bug is described here: #3

Description

Modified the nullable=False to nullable=true for product_id and subcategory_id for the Resource model.

Screenshots (if appropriate):

Before

Screen Shot 2021-10-21 at 11 03 57 PM

After

Screen Shot 2021-10-21 at 10 30 24 PM

Brought this additional bug to the attention of maintainers: Need the added category image to display on the home page

Screen Shot 2021-10-21 at 10 30 50 PM

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (improves application but is not new functionality nor a bug fix)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. -- N/A

@Abdur-rahmaanJ
Copy link
Member

Good btw just don't leave a space between x and ] then the checkbox will appear nice!

@Abdur-rahmaanJ Abdur-rahmaanJ merged commit e5164e1 into shopyo:dev Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants