Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Made a logo for issue#7 #8

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Made a logo for issue#7 #8

merged 1 commit into from
Oct 11, 2021

Conversation

VaithiSniper
Copy link
Contributor

Logo for ShopCube

Description

I've made a logo with blender. I've made use of a cube (pun on the name, and simple cart design along with the brandname). Please review it and let me if I need to add anything.
Issue in reference :

Motivation and Context

Made a logo since requested

#7 (comment)

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (improves application but is not new functionality nor a bug fix)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->
N/A
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I've made a logo with blender. I've made use of a cube (pun on the name, and simple cart design along with the brandname). Please review it and let me if I need to add anything.
Issue in reference : #7 (comment)
@VaithiSniper VaithiSniper mentioned this pull request Oct 10, 2021
@VaithiSniper
Copy link
Contributor Author

Also can you please add hacktoberfest to the repo topic? I want this pr to count towards hacktoberfest.

https://hacktoberfest.digitalocean.com/

Screenshot (630)

@Abdur-rahmaanJ
Copy link
Member

@VaithiSniper added hacktoberfest but where is the logo?

@VaithiSniper
Copy link
Contributor Author

It's in the pr. Do you want me to send it here?

@Abdur-rahmaanJ
Copy link
Member

But the pr is here ...

@rehmanis
Copy link
Collaborator

rehmanis commented Oct 11, 2021

@Abdur-rahmaanJ it's here. see the logo.png file.

@VaithiSniper
Copy link
Contributor Author

@rehmanis yea he's right. Did you find it? How'd you like it?

@rehmanis
Copy link
Collaborator

@VaithiSniper looks great. Good job.

@Abdur-rahmaanJ
Copy link
Member

@VaithiSniper Great! Sorry i was on mobile. Cool! Last thing, can you open another PR adding it to the readme? Thanks!

@Abdur-rahmaanJ Abdur-rahmaanJ merged commit 2677176 into shopyo:dev Oct 11, 2021
@VaithiSniper
Copy link
Contributor Author

Yes sure!

@VaithiSniper
Copy link
Contributor Author

#9 (comment)
I've made a PR for the same. Check and lemme know. :D

@Abdur-rahmaanJ
Copy link
Member

@VaithiSniper For now ok!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants