Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new linker pipeline on iOS #1810

Merged
merged 8 commits into from
Mar 28, 2024
Merged

feat: use new linker pipeline on iOS #1810

merged 8 commits into from
Mar 28, 2024

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Mar 22, 2024

Teach shorebird patch ios how to use the new linker pipeline when available.

@eseidel
Copy link
Contributor

eseidel commented Mar 24, 2024

Is this what I need to test the new object pool linker? (I presume so).

@bryanoltman
Copy link
Contributor Author

Yep - this just adds the gen snapshot path and path to the kernel file to the aot-tools link command call

@eseidel eseidel marked this pull request as ready for review March 28, 2024 18:22
@eseidel eseidel changed the title Add gen_snapshot and kernel flags to aot_tools link feat: use new linker pipeline on iOS Mar 28, 2024
Co-authored-by: Felix Angelov <felix@shorebird.dev>
@eseidel eseidel enabled auto-merge (squash) March 28, 2024 18:26
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.96%. Comparing base (3b0f2e4) to head (a5ca14b).

❗ Current head a5ca14b differs from pull request most recent head 25685de. Consider uploading reports for the commit 25685de to get more accurate results

Files Patch % Lines
...s/shorebird_cli/lib/src/executables/aot_tools.dart 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1810      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          173      173              
  Lines         5403     5419      +16     
===========================================
+ Hits          5403     5417      +14     
- Misses           0        2       +2     
Flag Coverage Δ
shorebird_cli 99.95% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseidel eseidel merged commit ed1b7c5 into main Mar 28, 2024
6 checks passed
@eseidel eseidel deleted the bo/linker-patch branch March 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants