Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): warn on low link percentages #1832

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

felangel
Copy link
Contributor

Description

  • feat(shorebird_cli): warn on low link percentages

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Mar 28, 2024
@felangel felangel self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (22a17a9) to head (b1a1f14).
Report is 1 commits behind head on main.

❗ Current head b1a1f14 differs from pull request most recent head 54d4101. Consider uploading reports for the commit 54d4101 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1832   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         5455      5472   +17     
=========================================
+ Hits          5455      5472   +17     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 3daff4f into main Mar 28, 2024
6 checks passed
@felangel felangel deleted the feat/shorebird-cli-warn-for-low-link-percentage branch March 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants