Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): don't prompt users for confirmation if we can't accept input via stdin #1845

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

If running in a terminal-less environment, Shorebird should not prompt for user confirmation.

Fixes #1705

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0e14f8b) to head (636fc29).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1845   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         5478      5479    +1     
=========================================
+ Hits          5478      5479    +1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We may still want to consider a "--no-confirm" or "--non-interactive" or whatever the pattern is.

@bryanoltman bryanoltman merged commit 7be7f4e into main Apr 1, 2024
8 checks passed
@bryanoltman bryanoltman deleted the bo/has-terminal branch April 1, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: shorebird hangs when run under fastlane
2 participants