Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): don't allow iOS releases to be created with Flutter < 3.19.5 #1864

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Apr 4, 2024

Description

Disallow iOS releasing with Flutter <3.19.5 to prepare for 1.0.

Fixes #1863

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4f221a5) to head (a5447fa).
Report is 1 commits behind head on main.

❗ Current head a5447fa differs from pull request most recent head 993a2b7. Consider uploading reports for the commit 993a2b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1864   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         5488      5497    +9     
=========================================
+ Hits          5488      5497    +9     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman enabled auto-merge (squash) April 4, 2024 18:42
@bryanoltman bryanoltman merged commit cbbe2ce into main Apr 4, 2024
6 checks passed
@bryanoltman bryanoltman deleted the bo/ios-min-flutter-version branch April 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable releasing with versions of ios prior to 3.19.5
3 participants