Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): run CI on Windows and Linux #1873

Merged
merged 12 commits into from
Apr 8, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Fixes #1860

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (8309934) to head (551aebd).

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #1873       +/-   ##
============================================
- Coverage   100.00%   87.83%   -12.17%     
============================================
  Files          172      172               
  Lines         5410     5411        +1     
============================================
- Hits          5410     4753      -657     
- Misses           0      658      +658     
Flag Coverage Δ
artifact_proxy 100.00% <ø> (ø)
discord_gcp_alerts 100.00% <ø> (ø)
jwt 100.00% <ø> (ø)
redis_client 100.00% <ø> (ø)
scoped 100.00% <ø> (ø)
shorebird_cli 84.26% <ø> (-15.74%) ⬇️
shorebird_code_push_client 100.00% <ø> (ø)
shorebird_code_push_protocol 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman enabled auto-merge (squash) April 8, 2024 19:50
@bryanoltman bryanoltman merged commit 36df219 into main Apr 8, 2024
24 of 25 checks passed
@bryanoltman bryanoltman deleted the bo/cli-test-windows-linux branch April 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: run shorebird_cli tests on windows and linux
3 participants