Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): allow specification of android target-platforms #1883

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Support target-platforms option on Android release and patch commands.

DRAFT because I need to add a couple tests.

Fixes #1734

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (38fa848) to head (f545b96).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       173    +1     
  Lines         5419      5447   +28     
=========================================
+ Hits          5419      5447   +28     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman marked this pull request as ready for review April 9, 2024 18:47
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the argument name/description

@bryanoltman bryanoltman merged commit d34507d into main Apr 9, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/android-archs branch April 9, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: allow Android release to use subset of available target platforms
2 participants