feat: adding message with link to the release when releasing an existing release #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
============================================
- Coverage 100.00% 87.93% -12.07%
============================================
Files 173 174 +1
Lines 5446 5454 +8
============================================
- Hits 5446 4796 -650
- Misses 0 658 +658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The links aren't secret, btw. :) You don't need to scratch yours out. We separately have a bug about doing a better job of hiding potentially sensitive information in our logs: #1770 |
eseidel
approved these changes
Apr 12, 2024
felangel
reviewed
Apr 15, 2024
felangel
reviewed
Apr 15, 2024
|
|
||
| void main() { | ||
| group('ShorebirdWebConsole', () { | ||
| test('linkTo returns the expected link to the root of the site', () { |
There was a problem hiding this comment.
Suggested change
| test('linkTo returns the expected link to the root of the site', () { | |
| test('linkTo returns the correct link relative to the root of the console', () { |
eseidel
approved these changes
Apr 15, 2024
felangel
reviewed
Apr 15, 2024
packages/shorebird_cli/test/src/shorebird_web_console_test.dart
Outdated
Show resolved
Hide resolved
bryanoltman
reviewed
Apr 15, 2024
felangel
reviewed
Apr 15, 2024
bryanoltman
reviewed
Apr 15, 2024
packages/shorebird_cli/test/src/code_push_client_wrapper_test.dart
Outdated
Show resolved
Hide resolved
bryanoltman
approved these changes
Apr 15, 2024
felangel
approved these changes
Apr 15, 2024
felangel
reviewed
Apr 15, 2024
packages/shorebird_cli/test/src/shorebird_web_console_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Angelov <felix@shorebird.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new message to the shorebird release [any] that will print a link to the release on the console when trying to run release in a version number that already exists!
Fixes #1890
Output
Type of Change