fix(shorebird_cli): flaky windows failure due to pkg:archive
#1906
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 174 174
Lines 5476 5476
=========================================
Hits 5476 5476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # We're using a specific commit because the latest published version (3.4.10) | ||
| # does not include a sync close API for ZipFileEncoder. | ||
| # https://github.com/brendan-duncan/archive/commit/94bf62410e9a073451bda0d851a07e8b8863bde4 | ||
| # This was causing a flaky test on windows when using `shorebird preview` | ||
| # https://github.com/shorebirdtech/shorebird/issues/1902 | ||
| archive: | ||
| git: | ||
| url: https://github.com/brendan-duncan/archive |
There was a problem hiding this comment.
Maybe leave a TODO here noting that we should switch away from a specific commit once a release containing the API we need is published
| # https://github.com/shorebirdtech/shorebird/issues/1902 | ||
| archive: | ||
| git: | ||
| url: https://github.com/brendan-duncan/archive |
There was a problem hiding this comment.
Nit since this might be exaggerated concerns: Usually when I stumble in cases like this, I tend to fork the repo under a org that I have control, just to be safe that this commit will not vanish.
I know the odds of that happening is not much though, but it don't hurt to be overzealous haha
There was a problem hiding this comment.
Yeah I thought about that but it seemed like overkill. Ideally we'll move away from this as soon as the next version is published.
Description
pkg:archive(closes tests: flaky windows preview test #1902)Type of Change