Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): ensure release artifacts are all built using the same flutter revision #1911

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Apr 16, 2024

Description

Screenshot 2024-04-16 at 1 51 07 PM

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.83%. Comparing base (2972919) to head (dc69224).

❗ Current head dc69224 differs from pull request most recent head d57bcee. Consider uploading reports for the commit d57bcee to get more accurate results

Files Patch % Lines
.../lib/src/commands/release/release_ios_command.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1911       +/-   ##
===========================================
- Coverage   99.98%   87.83%   -12.15%     
===========================================
  Files         174      174               
  Lines        5476     5491       +15     
===========================================
- Hits         5475     4823      -652     
- Misses          1      668      +667     
Flag Coverage Δ
shorebird_cli 84.32% <73.33%> (-15.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel enabled auto-merge (squash) April 16, 2024 18:57
@felangel felangel merged commit 3dc991c into main Apr 16, 2024
9 checks passed
@felangel felangel deleted the fix/multiple-releases-with-different-flutter-revisions branch April 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: patch created with wrong snapshot version
2 participants